move compress native into plugin repo #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
fab-10
reviewed
Feb 19, 2024
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
fab-10
approved these changes
Feb 20, 2024
letypequividelespoubelles
pushed a commit
that referenced
this pull request
Feb 22, 2024
* move compress native into plugin repo Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> * spotless and add a missing header Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> * some cleanup Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> --------- Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the native implementation here.
The native lib is built locally and added as a resource to the jar file (as well as the dict file).
When building the besu-plugins jar file now some additional tools are needed (like the go compiler)
Currently only the locally built native library is added to the jar file. For the release we need to make sure that the build is running on the right platform (I assume linux x86-64)