Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalarMulFixedBase and AddFixedPoint APIs #193

Closed
yelhousni opened this issue Dec 9, 2021 · 1 comment
Closed

ScalarMulFixedBase and AddFixedPoint APIs #193

yelhousni opened this issue Dec 9, 2021 · 1 comment
Labels
consolidate strengthen an existing feature
Milestone
v0.7.0

Comments

@yelhousni
Copy link
Contributor

ScalarMulFixedBase(api frontend.API, x, y interface{}, scalar frontend.Variable, curve EdCurve) and ScalarMulNonFixedBase(api frontend.API, p1 *Point, scalar frontend.Variable, curve EdCurve) have different APIs. Same for AddGeneric and AddFixedPoint used inside the scalar mul functions. While there is a difference constraints-wise, this should be hidden by the API.
@yelhousni yelhousni added the consolidate strengthen an existing feature label Dec 9, 2021
@gbotrel gbotrel modified the milestones: v0.6.0, v0.7.0 Dec 20, 2021
@yelhousni
Copy link
Contributor Author

Fixed in #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consolidate strengthen an existing feature
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
2 participants
@gbotrel @yelhousni