Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ZkTracer initialization time #720

Merged

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented May 20, 2024

When doing load testing on eth_sendRawTransaction with transaction simulation enabled, we've noticed that ZkTracer takes more than 20% of the time, on loading the opcode and the spillings.

image This RP Improves ZkTracer initialization time by doing only once Opcodes and spillings loading from disk resources. This is done when the class is loaded, opcodes and spillings are initialized is a static way.

Fixes issue #716

Improve ZkTracer initialization time by doing only once Opcodes and spillings loading from disk resources

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
@ahamlat ahamlat marked this pull request as ready for review May 20, 2024 15:06
@ahamlat
Copy link
Contributor Author

ahamlat commented Jul 9, 2024

@letypequividelespoubelles @powerslider This PR is already installed on different environment with the other release process. Can we merge it with this new version ?

@letypequividelespoubelles
Copy link
Collaborator

I'll let @powerslider or @OlivierBBB answer as I'm off and idk where we are in merging our hub PR which might creates new conflicts

@powerslider powerslider force-pushed the perf/issue-716/improve-performance-ZkTracer-contructor branch from 9af0afd to 5bc7ae0 Compare July 19, 2024 14:44
@powerslider powerslider merged commit 510d494 into arith-dev Jul 19, 2024
5 checks passed
@powerslider powerslider deleted the perf/issue-716/improve-performance-ZkTracer-contructor branch July 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants