Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Stop supporting deprecated Portal functions #789

Open
alainncls opened this issue Oct 31, 2024 · 0 comments
Open

[TASK] Stop supporting deprecated Portal functions #789

alainncls opened this issue Oct 31, 2024 · 0 comments

Comments

@alainncls
Copy link
Collaborator

When we introduced the "Modules V2" feature, some new functions were added to the Portal contract, to make sure we didn't break previous behaviours of already deployed Portals.

One way to ensure that newly deployed Portal contracts don’t support the deprecated functions anymore is the introduction of a new contract, AbstractPortalV2, that only supports the new set of functions; that approach would be similar to the introduction of AbstractModuleV2.

The original AbstractPortal contract should then be kept unaltered. Similar steps should be taken for concrete portals such as DefaultPortal, i.e., a new DefaultPortalV2 should inherit from AbstractPortalV2 and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for development
Development

No branches or pull requests

2 participants