Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing conflated traces files for linea_generateConflatedTracesToFileV2 requests #1598

Closed
jonesho opened this issue Dec 2, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jonesho
Copy link

jonesho commented Dec 2, 2024

When handling linea_generateConflatedTracesToFileV2 requests, we should check if the conflated-traces file is already existed in the file system, and only re-generate the conflated-traces file if no corresponding file is found.

This could save a lot of computing resources especially when coordinator restarts (which might re-send a great deal of linea_generateConflatedTracesToFileV2 requests to besu trace node for batches that had been requested before), also we had a Sepolia incident (940) that was due to the long duration for besu traces node to generate the conflated traces file of a specific block range, which resulted in failed response and could be avoided if this feature were in place.

@jonesho jonesho added the enhancement New feature or request label Dec 2, 2024
@jonesho
Copy link
Author

jonesho commented Jan 7, 2025

@FlorianHuc I'd like to close this, but just want to know if the linea-tracer plugin is going to implement the reuse logic or we decided not to do anything at all?

@jonesho jonesho closed this as completed Jan 7, 2025
@jonesho
Copy link
Author

jonesho commented Jan 7, 2025

Closed as we decided not to do anything given two main reasons: it is not so slow, and the last bugs was actual non deterministic traces, so reusing them would have been worst

@jonesho jonesho reopened this Jan 7, 2025
@jonesho jonesho closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants