Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Eth2Genesis Event - (Deposit_Contract PR #22) #493

Closed
schroedingerscode opened this issue Mar 15, 2019 · 0 comments
Closed

Update Eth2Genesis Event - (Deposit_Contract PR #22) #493

schroedingerscode opened this issue Mar 15, 2019 · 0 comments
Assignees
@dangerousfood
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want my Eth2Genesis event type to comply with the most most recent ABI so that Eth2Genesis events behave as expected and per spec in Artemis.

Acceptance Criteria

  • deposit_count is a new field of type bytes[8] added between the 2 existing fields in Eth2Genesis event.
  • get_deposit_count is a new function with no parameters and return type bytes[8] that returns self.to_little_endian_64(self.deposit_count)

Additional Information

See ethereum/deposit_contract#22
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Mar 15, 2019
@schroedingerscode schroedingerscode added this to the Beacon Chain v0.5.0 Spec milestone Mar 15, 2019
@dangerousfood dangerousfood self-assigned this Mar 29, 2019
@dangerousfood dangerousfood mentioned this issue Mar 29, 2019
Merged
5 tasks
@jrhea jrhea closed this as completed May 8, 2019
@jrhea jrhea mentioned this issue May 8, 2019
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dangerousfood dangerousfood

Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dangerousfood @jrhea @schroedingerscode