Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder API messages must be signed with domain obtained by compute_domain(DOMAIN_APPLICATION_BUILDER) #5613

Closed
Tracked by #5396
tbenr opened this issue May 28, 2022 · 0 comments · Fixed by #5624
Closed
Tracked by #5396

Builder API messages must be signed with domain obtained by compute_domain(DOMAIN_APPLICATION_BUILDER) #5613

tbenr opened this issue May 28, 2022 · 0 comments · Fixed by #5624
Assignees
@StefanBratanov

Comments

@tbenr
Copy link
Contributor

tbenr commented May 28, 2022 •
edited
Loading

When signing\verifying signatures, I think we are computing domain in the wrong way (SignedValidatorRegistration, should apply to SignedBuilderBid).
It should not be fork\genesis dependant.

https://github.com/ethereum/builder-specs/blob/e912fa8c6727fa456106cc85cb94fc4ab0f8d251/specs/builder.md#signing

https://github.com/ethereum/consensus-specs/blob/20a90f1df7c5bf1eda45122e6a74abc07e02fd98/specs/phase0/beacon-chain.md#compute_domain

So we should use: MiscHelpers#computeDomain(Bytes4)
@tbenr tbenr mentioned this issue May 28, 2022
Closed
34 tasks
@tbenr tbenr changed the title API messages must be signed with domain obtained by compute_domain(DOMAIN_APPLICATION_BUILDER) Builder API messages must be signed with domain obtained by compute_domain(DOMAIN_APPLICATION_BUILDER) May 28, 2022
@StefanBratanov StefanBratanov self-assigned this May 30, 2022
@tbenr tbenr mentioned this issue May 30, 2022
Merged
2 tasks
@StefanBratanov StefanBratanov mentioned this issue May 30, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBratanov StefanBratanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change domain computation for signing builder api message StefanBratanov/teku
2 participants
@StefanBratanov @tbenr