Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder_boost_factor to blockV3 validator API #7851

Closed
Tracked by #7390
zilm13 opened this issue Dec 22, 2023 · 2 comments · Fixed by #7936
Closed
Tracked by #7390

Add builder_boost_factor to blockV3 validator API #7851

zilm13 opened this issue Dec 22, 2023 · 2 comments · Fixed by #7936
Assignees

Comments

@zilm13
Copy link
Contributor

zilm13 commented Dec 22, 2023

Description

See appropriate blockV3 API section: https://github.com/ethereum/beacon-APIs/blob/master/apis/validator/block.v3.yaml#L46-L78
The feature is similar to our validators-builder-bid-challenge-percentage but since the change validator will be able to set it via blockV3 call for any block production request.
We should also decide whether blockV3 overrides BN settings (if any).

@tbenr
Copy link
Contributor

tbenr commented Jan 14, 2024

related to #7779

@tbenr
Copy link
Contributor

tbenr commented Jan 26, 2024

@zilm13 I think values coming from VC should override BN value, which I consider it as a default.
VC represents the staker, which have the ultimate right to decide how the flow should behave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants