Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3s reload of validator pubkeys #8742

Open
franjoespejo opened this issue Oct 17, 2024 · 2 comments
Open

w3s reload of validator pubkeys #8742

franjoespejo opened this issue Oct 17, 2024 · 2 comments
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@franjoespejo
Copy link

Teku implements the w3signer standard https://docs.teku.consensys.io/how-to/use-external-signer/use-web3signer, but it is unknown when the validator client requests the pubkeys to the w3s. For some w3s implementations, as diva (https://docs.divastaking.net/) the pubkeys array in the response is changing, therefore it would need the validator client to periodically check the pubkeys the w3s is signing for in order to keep it up to date.

@rolfyone
Copy link
Contributor

Thanks for raising - some notes.

Teku will reload when it receives a HUP signal, this is the preferred method.

I'm not sure I'd ideally want the VC polling constantly to find new keys, it sounds like a mixed concern, and is only really in the case where you're trying to generically load all keys from a URL, which is only really 1 use case.

We could potentially add a flag to allow the VC to specify a reload interval, but IMO it certainly shouldn't be default behaviour.

@rolfyone rolfyone added the enhancement 🕵️‍♀️ New feature or request label Oct 20, 2024
@franjoespejo
Copy link
Author

franjoespejo commented Oct 22, 2024

Thanks for checking in detail. Although that won't be the default option, it would be great to have it. It would let us to work with Teku vc seamlessly since it would enable vc to consume the w3s service all the time non-stop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@rolfyone @franjoespejo and others