Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] executeWithRetry is not work #293

Closed
jiachinzhao opened this issue Feb 2, 2023 · 3 comments
Closed

[BUG] executeWithRetry is not work #293

jiachinzhao opened this issue Feb 2, 2023 · 3 comments
Assignees

Comments

@jiachinzhao
Copy link

Describe the bug
executeWithRetry is not work
image
the reason is req.Body can only be readed once.
when req.Body is readed by one clickhouse and clickhouse shutdown, executeWithRetry to another clickhouse will lead to 400 bad request, since req.Body will be empty

To Reproduce
Steps to reproduce the behavior.

set 2 backend clickhouse-server
set config retry_number > 0

  1. send request to chproxy
  2. shutdown one clickhouse
  3. request will failed

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment information
Information about OS, chproxy and Clickhouse versions on which issue occures.

Additional context
Add any other context about the problem here.

@mga-chka
Copy link
Collaborator

mga-chka commented Feb 2, 2023

Thanks for the issue, FYI I warned the creators of this feature. They'll take a look at it within a few days.

@gontarzpawel
Copy link
Contributor

Hello @jiachinzhao, can you tell us if the issue is present for both POST and GET requests? From your description it sounds that retry mechanism does not work while chproxy used with POST

@mga-chka
Copy link
Collaborator

since the PR fixing the issue was merged, I'm closing this issue.
We will try to release a new version of chproxy next week.
Feel free to reopen the issue is the fix is not enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants