-
Notifications
You must be signed in to change notification settings - Fork 113
Description
We have a number of network locations for our common files, for instance PLT's, which we access via projects in Eclipse.
Having a look at doing the same with Phoebus, the best idea I could come up with was accessing them through Top Resources. I have trialed some changes to allow File Browser to be opened via Top Resources.
The main change is to remove the query component before passing the URI to FileBrowserApp. This means the path to the repo can be added to settings.ini, under top_resources:
org.phoebus.ui/top_resources= … | file:///path_to_common_folder/Common_PLTs?app=file_browser, Common PLT | …
I have also added code to show the current folder name in the tab. Having a few File Browsers open can lead to clicking on a few to find the tab you want. The tab name is updated when the user sets a new path, either via right click or by entering a new path.
I wasn't sure the best way to format the tab name - the only other tab I could see that displays the app name and another name is Display Editor. I put forward a few suggestions on formats to my colleagues and they suggested that 'File Browser (foldername)' looked the best out of the options.
As it stands, this is how it looks:
Top Resources:

I will open a PR with the modified code.
Thanks.

