-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
className props was removed #247
Comments
As of, d8df671, any props not specified in I guess I need to update the typings file to include an indexer, to allow for any other props? Correct me if I'm wrong – I am not too clued up on TypeScript typings: export interface ReactPlayerProps {
url?: string | string[] | SourceProps[];
playing?: boolean;
loop?: boolean;
// ...
[otherProps: string]: any;
} |
I tried adding the actual attributes types from the react types package, but a few properties of the ReactPlayer props (onProgress, onError, ...) conflicts with the DOMAttributes interface which has different definitions for those. So I guess you general indexer is our only solution for now :/ |
I saw in the last update that 'className' was removed from the props in the typescript types. That property was very important since it allows to access and manipulate the style of the
ReactPlayer
component. Is there a preferred way to deal with this ? i would rather not create another div (since the component already creates 2 of those) around it just to style it.The text was updated successfully, but these errors were encountered: