-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to force SSL on Twitch #367
Comments
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
Dec 23, 2018
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
May 23, 2020
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
philip-luther
added a commit
to philip-luther/react-player
that referenced
this issue
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I have recently notified that Twitch doesn't show Create Clip button on HTTP embedded players. React Player doesn't care about protocol in url prop because if I have HTTP page and ReactPlayer with url prop = https://www.twitch.tv/twitch it loads it as http://player.twitch....
I have debugged it is because of this kind of SDK_URL in Twitch.js
var SDK_URL = '//player.twitch.tv/js/embed/v1.js';
It is possible to add new prop (forceSSL for example) or load http/https //player.twitch.tv/js/embed/v1.js depend on url prop? I don't want to hack it locally.
As I noticed YouTube/Vimeo configs have hardcodded https sdk, maybe just add this to Twitch too.
The text was updated successfully, but these errors were encountered: