-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: pass back player instance in event callbacks #407
Comments
Fixed in |
@cookpete No worries, thanks so much! |
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
Dec 23, 2018
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
May 23, 2020
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
philip-luther
added a commit
to philip-luther/react-player
that referenced
this issue
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So, in our app, unfortunately, we need to wrap components with https://github.com/faceyspacey/react-universal-component, including
react-player
. Unfortunately because of the way React works, setting aref
property to a universal-wrapped component does not pass the ref to the underlying component like it does other props.This means that we can't ever attach a reference to
react-player
(without forking/rewriting the library). What would be nice is ifonReady()
/onPlay()
callbacks, etc passed back the player instance, so that we can use instance methods. Without any sort of callback mechanism, none of the instance methods are callable.By the way, this isn't specific to
react-universal-component
, but will be the case with any higher-order component that wrapsreact-player
.The text was updated successfully, but these errors were encountered: