Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundCloudConfig outdated in index.d.ts #588

Closed
thunderkid opened this issue Mar 5, 2019 · 0 comments
Closed

SoundCloudConfig outdated in index.d.ts #588

thunderkid opened this issue Mar 5, 2019 · 0 comments

Comments

@thunderkid
Copy link

The docs say that the following should be allowed:

config={{
    soundcloud: {
        preload: true,
    }
}

This actually does work, but in typescript it gives a compilation error since SoundCloudConfig does not contain preload?: boolean in index.d.ts. (You can obviously work around it by casting config as any as a temp solution.)

albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant