-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from version 1.2.1 to 1.11.1 #675
Comments
What URL are you trying to play? What props are you using? Can you recreate the problem in a forked jsFiddle? https://jsfiddle.net/sv5x3ug1
This looks like an issue with vimeo/player.js rather than this library. The error is from |
@cookpete The issue is when the Vimeo config preload is set to true, it prevents the Youtube videos from playing. I've recreated the issue on https://jsfiddle.net/m2yv8L4s/3/ |
@cookpete to give context, I'm dynamically passing urls from a server so in config I've got preload for both Youtube and Vimeo videos. In this case when loading Youtube videos, the preload video for Vimeo is also loading. |
I've just noticed something that may be related. In updating from 1.11.0 to 1.11.1, I suddenly start seeing a (distorted and pixellated) soundcloud player where I'd expect a youtube player. @eTheMan80 : Have you tried version 1.11.0 instead? |
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
I have upgraded the player from 1.2.1 to 1.11.1. There's an issue when trying to play Youtube videos, it instead plays Vimeo videos.
I expect all Youtube and Vimeo vidos to play depending on the url.
On the current version 1.2.1, I get a 404 error on the network tab using Chrome for this 'https://vimeo.com/api/oembed.json?url=https%3A%2F%2Fvimeo.com%2F127250231&autopause=false&autoplay=false&byline=false&portrait=false&title=false&url=https%3A%2F%2Fvimeo.com%2F127250231&loop=false'
The text was updated successfully, but these errors were encountered: