Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vimeo player] playback fails when swapping URLs too quickly #683

Closed
panzerstadt opened this issue Jul 30, 2019 · 1 comment
Closed

[Vimeo player] playback fails when swapping URLs too quickly #683

panzerstadt opened this issue Jul 30, 2019 · 1 comment

Comments

@panzerstadt
Copy link

panzerstadt commented Jul 30, 2019

Be sure to search for your issue before opening a new one.

Current Behavior

whe switching between urls too quickly, Vimeo player fails to load and stays black

Expected Behavior

vimeo player should play when urls change, or failure to load player should recover on next url load

Steps to Reproduce

  1. go to https://cookpete.com/react-player/
  2. click on Test A under Vimeo
  3. wait for it to play
  4. click on Test B for Vimeo and then quickly click on Test A again
  5. player stops playing, shows a black screen
  6. error is thrown in console: Player.js:41 ReactPlayer: the attempt to load https://vimeo.com/xxxxxxxxx is being deferred until the player has loaded
  7. further changes in vimeo urls are unable to resolve the problem

Other Information

does not seem to be an issue with other players (from the initial test on the website)

@cookpete
Copy link
Owner

cookpete commented Aug 9, 2019

I think this is due to this line of the Vimeo player which will kill any player mid-load if a new url arrives. The original video never gets a chance to onReady or onPlay and so the loadOnReady logic never kicks in.

albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants