-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Webpack 4 and Babel 7 #695
Comments
cookpete
added a commit
that referenced
this issue
Aug 18, 2019
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
philip-luther
added a commit
to philip-luther/react-player
that referenced
this issue
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@cookpete
This is exactly a regular issue. Just wanted to reach out to you. First off, excellent project you have here. It's hard to imagine how much work this took. Kudos to you!
I forked your repo in an attempt to fix the console.warn's of React lifecycle methods being deprecated in React 17 by re-implementing in
componentDidUpdate
. This led me down a bit of a rabbit hole in that npm packages used are a bit dated (e.g. Webpack 3, Babel < 7) and it seemed like a better choice to make the leap and break stuff by upgrading all to the latest packages. Anyhow, I did exactly that and ran into problem after problem but pushed through it and eventually got it to run and build.I thought it wouldn't be wise to create a pull request without first asking because the changes are massive. Totally understand if you don't have time for it but would be grateful if you could review the changes and provide any feedback. Thanks for your time!
https://github.com/jaytula/react-player/commits/master
The text was updated successfully, but these errors were encountered: