We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If playing any SoundCloud URL, 2 different callbacks are called when the songs end:
SoundCloud URL
onPause
onEnded
This behavior unfortunately mess up with possible controllers / auto-play Components which expects only onEnded when a song ends.
As per other type of URL (i.e. YouTube). Only onEnded is called when the songs end.
Sorry but I can't seem to make the fiddle page work, so I'll paste directly the code here:
<ReactPlayer url="https://www.youtube.com/watch?v=oFRbZJXjWIA" className="react-player" playing={true} controls width="100%" height="100%" onPlay={() => console.log("onPlay")} onPause={() => console.log("onPause")} onEnded={() => console.log("onEnded")} />
<ReactPlayer url="https://soundcloud.com/jonny-bones-jones/bob-marley-jammin" className="react-player" playing={true} controls width="100%" height="100%" onPlay={() => console.log("onPlay")} onPause={() => console.log("onPause")} onEnded={() => console.log("onEnded")} />
The text was updated successfully, but these errors were encountered:
89c0826
Thx for the fix ✌
Sorry, something went wrong.
Prevent Soundcloud onPause right before onEnded
1a42cfd
Fixes cookpete/react-player#879
35fa6e7
736beaa
No branches or pull requests
If playing any
SoundCloud URL
, 2 different callbacks are called when the songs end:onPause
onEnded
This behavior unfortunately mess up with possible controllers / auto-play Components which expects only
onEnded
when a song ends.Expected Behavior
As per other type of URL (i.e. YouTube).
Only
onEnded
is called when the songs end.Steps to Reproduce
Sorry but I can't seem to make the fiddle page work, so I'll paste directly the code here:
Scroll/wait until songs end.
Check console log.
Scroll/wait until songs end.
Check console log.
Environment
The text was updated successfully, but these errors were encountered: