Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type definition for ReactPlayerProps.onReady in v2 #884

Closed
jasperhartong opened this issue May 12, 2020 · 0 comments
Closed

Incorrect type definition for ReactPlayerProps.onReady in v2 #884

jasperhartong opened this issue May 12, 2020 · 0 comments

Comments

@jasperhartong
Copy link

In v2 onReady is invoked with the player instance, this is not reflected yet on the type definition.

https://github.com/CookPete/react-player/blob/32bb251a60f1a6449bd20e6dcf4c7dbfaeab02b7/index.d.ts#L92

Think it should be

onReady?(player: ReactPlayer): void;
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Correct typings for onReady
1270b55 
Fixes cookpete/react-player#884
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Correct typings for onReady
97a2637 
Fixes cookpete/react-player#884
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
@philip-luther
Correct typings for onReady
94717f9 
Fixes cookpete/react-player#884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasperhartong