Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail image fetched multiple times #927

Closed
mschipperheyn opened this issue Jun 11, 2020 · 0 comments
Closed

Thumbnail image fetched multiple times #927

mschipperheyn opened this issue Jun 11, 2020 · 0 comments

Comments

@mschipperheyn
Copy link

Current Behavior

I'm seeing thumbnail images being fetched with each reload. The results are not cached.

Expected Behavior

It doesn't make sense to me to use fetch for this. It would be better to hit the image url directly and allow the contents to be cached.

Steps to Reproduce

Environment

Other Information
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Add basic caching of preview thumbnails
28f6889 
Fixes cookpete/react-player#927
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Add basic caching of preview thumbnails
5f4d9fc 
Fixes cookpete/react-player#927
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
@philip-luther
Add basic caching of preview thumbnails
8a5e979 
Fixes cookpete/react-player#927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mschipperheyn