Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for iPad Pro user agent detection #1005

Closed
wants to merge 3 commits into from
Closed

Conversation

taitems
Copy link

@taitems taitems commented Sep 2, 2020

Closes #1004 - users can now load a video on an iPad Pro in default desktop mode.

@cookpete
Copy link
Owner

cookpete commented Sep 8, 2020

This PR was a bit of a mess (not sure what's going on with the syntax changes?) so I've just fixed it in 136836e. Published in v2.6.2.

@taitems
Copy link
Author

taitems commented Sep 9, 2020

Yep, all good thanks for fixing, I have prettier and/or editorconfig running in VSCode so they have a habit of reformatting files I touch.

That being said there's probably value in setting up an editorconfig or prettier config if you don't already have one?

Webmaster1116 added a commit to Webmaster1116/video-player that referenced this pull request May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this pull request Sep 9, 2022
philip-luther added a commit to philip-luther/react-player that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading issue on iPad Pro only ("request desktop site")
2 participants