Fix ReactPlayer refs not being set #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexivanov
commented
Apr 27, 2020
| @@ -42,7 +42,7 @@ export default class ReactPlayer extends Component { | |||
| showPreview: !!this.props.light | |||
| } | |||
|
|
|||
| refs = { | |||
| elementRefs = { | |||
There was a problem hiding this comment.
refs overshadows legacy React.Component prop and is overwritten.
|
Fixed separately in |
albanqoku
added a commit
to albanqoku/react-player
that referenced
this pull request
Feb 24, 2021
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
philip-luther
added a commit
to philip-luther/react-player
that referenced
this pull request
Nov 22, 2024
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue and where
playerandwrapperrefs are not set correctly inReactPlayer, causing instance methods to stop working. Tested with v2.0.0 and I think this version is the only one affected.Introduced in 9c9a4d4.