Fix player refs not setting correctly. #868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was already a PR for this at #866. Regardless, this should be fixed in |
|
Oh, nice. Thanks |
albanqoku
added a commit
to albanqoku/react-player
that referenced
this pull request
Feb 24, 2021
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
philip-luther
added a commit
to philip-luther/react-player
that referenced
this pull request
Nov 22, 2024
`refs` is used internally by React Closes cookpete/react-player#868 Closes cookpete/react-player#866 Fixes cookpete/react-player#867 Fixes cookpete/react-player#861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I described an issue I encountered here on the demo.
#867
I then experienced this same problem in my own code, where
seekTowasn't working correctly. It turns out that the issue was actually far more widespread, and the ref just wasn't being set at all.When I logged out the object in
ReactPlayerthat was calledrefs, which was meant to hold two functions to set refs in child components, it was an empty object. This appears to be a reserved keyword that is presumably used by react, as it was being overridden with an empty object. Simply changing the property name fromrefstosetRefresolved the issue, and seeking behavior (among other things) now work correctly.In order to test: follow the steps in the issue I linked above, and notice the broken behavior. Then test the same behavior in this branch, and note it functioning correctly.