Too high startuptime #729
Replies: 5 comments 8 replies
-
|
Actually, you could use What do you think? @deathbeam |
Beta Was this translation helpful? Give feedback.
-
|
I know that, but I just don't like the way Lua plugins often have much higher startuptime than legacy Vimscript plugins just because they often try to load the whole plugin on startup, which is just unnecessary. Also among many active plugin managers for Neovim, lazy.nvim is the only one that supports such For the PR, I will need to make some refactoring. But I would like to ask some questions first.
The result is that all directories in 'runtimepath' will be searched
for the "plugin" sub-directory and all files ending in ".vim" or
".lua" will be sourced (in alphabetical order per directory),
also in subdirectories. First "*.vim" are sourced, then "*.lua" files,
per directory.That would also save users from having to run the function |
Beta Was this translation helpful? Give feedback.
-
|
Im not sure from where is the 80ms coming from, looking at log if I include the plenary loading there as well its like 5ms: which is similar to something like fzf-lua. The plugin already loads only necessary stuff in setup too. You could technically move some requires to setup directly, but requires in any other function that is called more than once are unacceptable. I dont rly see a reason to change how default config works either, its fine as is. |
Beta Was this translation helpful? Give feedback.
-
|
I use lazy.nvim profile and here is the result I do use startuptime and here is what I got While it seems low if you take 261.938-250.462, but if you take 306.017-250.462, you get a number similar to what Lazy tells. Moreover, there is no reason |
Beta Was this translation helpful? Give feedback.
-
|
from timing it in my own config, whihc also includes optional fzf lua stuff. Idk, seems fine? could be better i guess but its also nowhere close to 40 times as slow as fzflua for me |
Beta Was this translation helpful? Give feedback.
-
|
@deathbeam I also tried with vim.opt.rtp:append('~/.local/share/nvim/lazy/fzf-lua/')
local t0 = vim.uv.hrtime()
vim.cmd.runtime('plugin/fzf-lua.lua')
print('FZF-lua loaded in ' .. tostring((vim.uv.hrtime() - t0) / (10^6)) .. ' miliseconds')Result |
Beta Was this translation helpful? Give feedback.
-
|
So that's a huge difference |
Beta Was this translation helpful? Give feedback.
-
|
Hmm tried it again while timing fzf-lua as well: Fzf-lua modules loaded in 7.74ms
Fzf-lua setup completed in 8.29ms
Copilot modules loaded in 3.77ms
Copilot setup completed in 7.23msand copilot loads for me even faster than fzf-lua, so im very confused about what is happening in your config |
Beta Was this translation helpful? Give feedback.
-
|
and this is what i did for the timings diff --git a/nvim/.config/nvim/lua/config/copilot.lua b/nvim/.config/nvim/lua/config/copilot.lua
index 3c12ea3..11dec2a 100644
--- a/nvim/.config/nvim/lua/config/copilot.lua
+++ b/nvim/.config/nvim/lua/config/copilot.lua
@@ -9,11 +9,13 @@ vim.g.copilot_proxy_strict_ssl = 0
vim.keymap.set('i', '<S-Tab>', 'copilot#Accept("\\<S-Tab>")', { expr = true, replace_keycodes = false })
-- Copilot chat
+local start_time = vim.loop.hrtime()
local chat = require('CopilotChat')
local actions = require('CopilotChat.actions')
local select = require('CopilotChat.select')
local integration = require('CopilotChat.integrations.fzflua')
local cutils = require('CopilotChat.utils')
+print(string.format("Copilot modules loaded in %.2fms", (vim.loop.hrtime() - start_time) / 1e6))
chat.setup({
model = 'claude-3.5-sonnet',
@@ -113,6 +115,7 @@ chat.setup({
}
}
})
+print(string.format("Copilot setup completed in %.2fms", (vim.loop.hrtime() - start_time) / 1e6))
utils.au('BufEnter', {
pattern = 'copilot-*',
diff --git a/nvim/.config/nvim/lua/config/finder.lua b/nvim/.config/nvim/lua/config/finder.lua
index e3b8eda..06f32ed 100644
--- a/nvim/.config/nvim/lua/config/finder.lua
+++ b/nvim/.config/nvim/lua/config/finder.lua
@@ -5,7 +5,9 @@ local desc = utils.desc
desc('<leader>f', 'Find')
+local start_time = vim.loop.hrtime()
local fzf_lua = require('fzf-lua')
+print(string.format("Fzf-lua modules loaded in %.2fms", (vim.loop.hrtime() - start_time) / 1e6))
fzf_lua.setup({
'fzf-tmux',
file_icon_padding = ' ',
@@ -45,6 +47,7 @@ fzf_lua.register_ui_select({
['--tmux'] = 'bottom,50%',
},
})
+print(string.format("Fzf-lua setup completed in %.2fms", (vim.loop.hrtime() - start_time) / 1e6))
-- https://github.com/ibhagwan/fzf-lua/issues/602
local function w(fn) |
Beta Was this translation helpful? Give feedback.
-
|
Its possible your filesystem is very slow and that might've been causing issues, there was mkdir code in tiktoken (only when tiktoken is actually being used), i moved it elsewhere, maybe try if anything changed? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Today CopilotChat.nvim has too hight startuptime (80ms).
I think I will send a pull request that refactor it a bit to lower startuptime. In the main file (init.lua), I will make it not require any other module at script level (but only in function level). This is to avoid unnecessarily loading all modules at startuptime. What do you think?
Beta Was this translation helpful? Give feedback.
All reactions