Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesizer doesn't work in Python 3.8+ #634

Closed
ghost opened this issue Jan 20, 2021 · 7 comments
Closed

Synthesizer doesn't work in Python 3.8+ #634

ghost opened this issue Jan 20, 2021 · 7 comments

Comments

@ghost
Copy link

ghost commented Jan 20, 2021

The synthesizer uses Tensorflow 1.x, which is not supported in Python 3.8 or higher. We need help to upgrade the synthesizer model.

  • In Tensorflow v2 compatibility #370, we tried upgrading the code to Tensorflow 2.x. However, the differences between TF 1.x and 2.x are significant. Even switching to an existing TF 2.x Tacotron model would require an overhaul of the training and inference scripts.
  • The preferred approach is to replace it with a Pytorch-based synthesizer. This is something we discussed in Pytorch synthesizer #447. I submitted a PR Pytorch synthesizer #472, which was not accepted due to bad voice quality. The heavy lifting is done but more work is needed to improve the model.

Please respond to this issue or submit a pull request to help out.

@ghost ghost added the help wanted Extra attention is needed label Jan 20, 2021
@vinamramunot-tech
Copy link

I am also facing the same issue. I tried to see if there was packages in tensorflow_addon however couldn't find it. Is there an update to this? @blue-fish

@ghost
Copy link
Author

ghost commented Jan 23, 2021

The information above is still current. My fork works with Python 3.8, but it's not the long-term solution to this problem. Someone else needs to step up and contribute a better model.

@vinamramunot-tech
Copy link

@blue-fish Although I am not knowledgeable but I can give it a try. Is there something that we can start on?

@ghost
Copy link
Author

ghost commented Jan 23, 2021

@vinamramunot-tech Actually I just found something that should improve my pytorch model. I'll report back in a few days if it worked. #472 (comment)

@vinamramunot-tech
Copy link

@blue-fish thank you!! Let me know if I can be of any help.

@ghost
Copy link
Author

ghost commented Jan 25, 2021

@vinamramunot-tech It worked, and I expect to have a model for release within a week.

If you are available to help, it would be nice to add mixed precision training support. That will allow us to train better models on consumer GPUs with limited memory. If you have any interest in helping, leave a message in #487 and I'll let you know how you can get started.

@ghost
Copy link
Author

ghost commented Jan 25, 2021

Tentatively closing this since this issue doesn't require attention at this time.

@ghost ghost closed this as completed Jan 25, 2021
@ghost ghost removed the help wanted Extra attention is needed label Nov 12, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant