Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux 64-bit compilation requires -Wno-error (google code Issue 101) #36

Closed
zwetan opened this issue Dec 28, 2015 · 2 comments
Closed

Comments

@zwetan
Copy link
Member

zwetan commented Dec 28, 2015

https://code.google.com/p/redtamarin/issues/detail?id=101


seems similar to
Bug 654996: use target-specific variable to disable -Werror in these cases

https://bugzilla.mozilla.org/show_bug.cgi?id=654996

so in core/manifest.mk we do

ifeq (x86_64,$(TARGET_CPU))
ifeq ($(TARGET_OS),linux)
$(curdir)/AvmCore.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error
$(curdir)/CodegenLIR.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error -fpermissive
$(curdir)/exec-jit.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error
$(curdir)/exec-osr.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error
$(curdir)/InvokerCompiler.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error
$(curdir)/LirHelper.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error
$(curdir)/PoolObject.$(OBJ_SUFFIX): avmplus_CXXFLAGS += -Wno-error
endif
endif

and here the real problem

  • fixing bug in our source code, it's OK
  • going into the AVM2 source code to fix such bugs is possible but not wanted
@zwetan
Copy link
Member Author

zwetan commented Dec 28, 2015

this should have been solved with the [Linux Ubuntu Setup(https://github.com/Corsaair/redtamarin/wiki/LinuxUbuntuSetup)

see src/core/manifest.mk
it is compatible with gcc 4.8.5 used in the setup

we should document how and where to disable -Werror for all compilers

@zwetan
Copy link
Member Author

zwetan commented Jan 16, 2016

solved

@zwetan zwetan closed this as completed Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant