-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PartialEq between &str/String and Addr #1669
Milestone
Comments
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When one of the sides is not normalized you can get unintended results. E.g.
Now if
blocked
iscosmos1jhg0e7s6gn44tfc5k37kr04sznyhedtc9rzys5
anduser_provided_address
iscosmos1jhg0e7s6gn44tfc5k37kr04sznyhedtc9rzys5
the check works fine. But if the perfectly valid formCOSMOS1JHG0E7S6GN44TFC5K37KR04SZNYHEDTC9RZYS5
is provided, this breaks.I'm sure the example is bad here but I hope you get what I mean. Equality checkes between Addr and &str or String are just not safe.
The text was updated successfully, but these errors were encountered: