Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Default implementation from IbcReceiveResponse #1779

Closed
webmaster128 opened this issue Jul 15, 2023 · 1 comment · Fixed by #1942
Closed

Remove Default implementation from IbcReceiveResponse #1779

webmaster128 opened this issue Jul 15, 2023 · 1 comment · Fixed by #1942
Milestone
2.0.0

Comments

@webmaster128
Copy link
Member

webmaster128 commented Jul 15, 2023 •
edited
Loading

Goes together with #1721
@webmaster128 webmaster128 added this to the 2.0.0 milestone Jul 15, 2023
@chipshort chipshort mentioned this issue Sep 29, 2023
Merged
@webmaster128
Copy link
Member Author

@chipshort let's do this independently of #1721. Now that IbcReceiveResponse::new requires the acknowledgement, we should remove IbcReceiveResponse::default.

@chipshort chipshort mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Remove Default impl for IbcReceiveResponse CosmWasm/cosmwasm
1 participant
@webmaster128