Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SEMANTICS.md #2253

Open
Kayanski opened this issue Sep 12, 2024 · 1 comment
Open

Update SEMANTICS.md #2253

Kayanski opened this issue Sep 12, 2024 · 1 comment

Comments

@Kayanski
Copy link

Kayanski commented Sep 12, 2024

The SEMANTICS.md file is very convenient to understand how executions, replies and submessages deal with the Response fields (events, data).

Cosmwasm 2.x introduced a new msg_responses field that is NOT documented in the SEMANTICS.md file.

Is it possible to update this file to have an explanation of how that field is handled during execution ?
And more generally, is it possible to update this file to 2.x specifics ?

Thanks

@chipshort
Copy link
Collaborator

Hey Kayanski,

Yes, the whole document is very outdated.
The msg_responses field just gets forwarded from the SDK, so maybe more information can be found there. x/wasm just takes what it gets from the SDK and combines it into one vec. The only thing it does different is the fact that one message from a contract can be translated into multiple sdk messages (does not happen for any of the preimplemented messages, but could be the case for custom messages), so x/wasm concatenates all the MsgResponses fields from all the message responses into one vec.

Thanks for bringing this point up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants