Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to cw3 spec #182

Closed
2 tasks done
ethanfrey opened this issue Dec 15, 2020 · 1 comment
Closed
2 tasks done

Updates to cw3 spec #182

ethanfrey opened this issue Dec 15, 2020 · 1 comment
Assignees
@ethanfrey

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Dec 15, 2020 •
edited
Loading

When testing cw3-flex, I found a few issues in the spec, where it assumes the state of the contract (current group) is equivalent to the state of the proposal. But for dynamic groups, we need a few more queries to get all relevant data:

  • QueryMsg::Proposal/ListProposal/ReverseProposal - include threshold here - the total weight can be different than that returned by QueryMsg::Threshold
  • QueryMsg::Vote returns Option<Vote> including the yes/no/abstain/veto given. However, to display this correctly we need to know the voting weight of the given voter at the time it was recorded (which can be different than current weight). VoteResponse needed the weight field from VoteInfo.
@ethanfrey ethanfrey mentioned this issue Dec 15, 2020
Merged
@ethanfrey ethanfrey self-assigned this Dec 15, 2020
@ethanfrey
Copy link
Member Author

Closed by #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanfrey ethanfrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethanfrey