Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multitest: Enforce validity checks for returned items #341

Closed
ethanfrey opened this issue Jul 22, 2021 · 0 comments · Fixed by #373
Closed

multitest: Enforce validity checks for returned items #341

ethanfrey opened this issue Jul 22, 2021 · 0 comments · Fixed by #373
Assignees
@hashedone
Labels
multi-test

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Jul 22, 2021 •
edited
Loading

wasmd enforced some constraints on the data we return. Let's assert them in multitest as well to help shake out bugs earlier. Some items:

  • Label in WasmMsg::Instantiate cannot be empty ("")
  • Returned attributes (also inside events) cannot have empty key or empty value
  • Returned attributes (also inside events) cannot start with _ (wasmd 0.18)
  • Returned events must have a type of length >= 2

Please add any more constraints here as you notice them in wasmd

Related to #348 (maybe both resolved in one PR?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hashedone hashedone

Labels
multi-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Responses validation in multi-test CosmWasm/cw-plus
2 participants
@ethanfrey @hashedone