Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define generic multitest module #387

Closed
ethanfrey opened this issue Aug 17, 2021 · 1 comment · Fixed by #425
Closed

Define generic multitest module #387

ethanfrey opened this issue Aug 17, 2021 · 1 comment · Fixed by #425
Assignees
Milestone

Comments

@ethanfrey
Copy link
Member

Related to #266

Something like Bank = Module<BankMsg, BankQuery>.

We can have a default NotImplemented implementation that we can use to handle all the other unsupported types of CosmosMsg, but include them in the switch. All have the same interface, which allows us to easy add support for other modules (Custom, Staking, IBC) without changing everything else.

Router should include multiple modules for these main types, but ::new() will just set as NotImplemented.

@hashedone
Copy link
Contributor

I was looking on this idea for half a day and I don't think it makes any sense. Those modules are not the same - Api is differing, as all modules should react on different enum variant.

Also most modules should probably contain no logic - just be mocked structures. I would just proceed with extracting better setup API (via #388), and then prepare transparent mockups of all needed subcomponents with mockall.

@ethanfrey ethanfrey self-assigned this Sep 6, 2021
@ethanfrey ethanfrey modified the milestones: v0.9.0, v0.10.0 Sep 13, 2021
@ethanfrey ethanfrey mentioned this issue Sep 15, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants