Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate range to range_raw #460

Closed
maurolacy opened this issue Oct 1, 2021 · 1 comment · Fixed by #576
Closed

Deprecate range to range_raw #460

maurolacy opened this issue Oct 1, 2021 · 1 comment · Fixed by #576
Assignees
Milestone

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Oct 1, 2021

After #432, we'll have full range deserialization working for Map.

Let's deprecate range in favour of range_de, keeping range as range_raw.

Regarding prefix vs. prefix_de, let's (try to) keep prefix_de as prefix, and remove the current prefix. That is, no prefix_raw impl, which will be confusing. That implies making range_raw work with / over prefix_de.

This also includes migrating the code in contracts to take advantage of the new key deserialization when useful.

Also, as part of this, let's improve traits segregation over Map and Prefix range-related methods, so that trait bounds are enforced only when strictly needed.

@ethanfrey
Copy link
Member

I support this.
I would target 0.11 for this, and get the new features in 0.10, so people can start opt-ing in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants