-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitest has errors with reply data #516
Comments
This was referenced Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Messages should return the standard x/wasm protobuf format in the data field when returned.
We do that now with
instantiate_reply
which does the proper proto wrapping, but it is set insideexecute_wasm
and is overwriten if any submessages return non-empty data on replyIdeally, we apply this wrapper after all submessages have been returned, but that is a bit tricky with the current logic flow (may need some non-trivial refactoring)
I also noticed that Execute and Migrate messages return the data raw, while there are proto wrappers for both of them.
I will add some failing tests.
The text was updated successfully, but these errors were encountered: