Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MultiIndex pk deserialization #531

Closed
maurolacy opened this issue Nov 4, 2021 · 3 comments
Closed

Improve MultiIndex pk deserialization #531

maurolacy opened this issue Nov 4, 2021 · 3 comments

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Nov 4, 2021

Signal the primary key deserialization type of MultiIndex using a PK trait or similar, like in UniqueIndex. (done in #568)

In passing, rename K to IK (Index Key) for clarity in both indexes. (done in #569)

If possible, make those PK traits automatic / inherited from the IndexedMap specification. That means, better encapsulation / coupling between IndexedMap and the *Index impls.

@maurolacy
Copy link
Contributor Author

maurolacy commented Dec 1, 2021

Breaking change, for 0.11, or 0.12.

@maurolacy maurolacy added the breaking Breaking changes label Dec 1, 2021
@ethanfrey ethanfrey modified the milestones: v0.11.0, v0.12.0 Dec 14, 2021
@ethanfrey
Copy link
Member

Is this done? @maurolacy

If so, let's close. If not, can you improve the description so we can follow up on it?

@maurolacy
Copy link
Contributor Author

This is "closed" by the index_trait procedural macro.

Implementing the third point in the description would require a significant refactor of IndexedMap and associated indexes.

So, I would say, let's close it as solved through a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants