-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of hooks.rs (not) as HashMap
#682
Comments
HashMap is not serialisable with our json lib as ordering is not deterministic. Do not use it anywhere. Also, since the process is "load struct from disk, deserialise, search", any performance gain HashMap would give would be offset by decreased performance of the deserialisation. The other approach is to store in a |
thx @ethanfrey , I appreciate the explainnation! 👍 |
Hi!
Getting to know the libraries while following TerraAcademy, I was wondering why hooks.rs is implemented as a
Vec
instead of an (allegedly more perfomant)HashMap
. Any reasons I'm not seeing? If not, I'd be happy to reimplement :)The text was updated successfully, but these errors were encountered: