-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply dispatch generation #429
Labels
part
Part of a bigger issue
Comments
jawoznia
added a commit
that referenced
this issue
Sep 10, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Sep 10, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Sep 12, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Sep 13, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Sep 18, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Sep 18, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Sep 19, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
jawoznia
added a commit
that referenced
this issue
Nov 20, 2024
Since this change would be breaking it's hidden behind `sv_replies` feature flag.
This was referenced Nov 20, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We keep the dispatching logic outside of the entry point and instead move it to a method like
dispatch_reply()
to provide reusability.The method should match over every generated ID and provide additional checks for result of the submessage.
In case the handler for success or failure is not defined we will simply forward the result.
Note that above approach requires methods for a single identifier to have the same fields received from the Payload.
You can also define a single handler for an identifier-result pair.
For above to work we have to provide some new functionality.
The text was updated successfully, but these errors were encountered: