Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return non redacted error content on IBC packet recv #1289

Closed
alpe opened this issue Mar 23, 2023 · 2 comments
Closed

Return non redacted error content on IBC packet recv #1289

alpe opened this issue Mar 23, 2023 · 2 comments
Assignees
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Mar 23, 2023

Current response in json is: {"error":"ABCI code: 5: error handling packet: see events for details"}
Instead of the default error constructor, we could pass the string directly

Note: Only for this case: https://github.com/CosmWasm/wasmd/blob/v0.31.0/x/wasm/keeper/relay.go#L135-L136

See also #1220

@alpe alpe added this to the v0.32.0 milestone Mar 23, 2023
@alpe alpe changed the title Return non redacted error content on Return non redacted error content on IBC packet recv Mar 23, 2023
@alpe
Copy link
Contributor Author

alpe commented Mar 24, 2023

Does it make sense to prevent empty error strings? Technically it is not an issue and would save some gas for the relayer.
ICS-29 fees should give an incentive for short messages

This was referenced Mar 27, 2023
@0xekez
Copy link
Contributor

0xekez commented Mar 29, 2023

this would be a really nice feature 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants