Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Config to wasmvm and make WasmLimits available to contract dev #1986

Closed
chipshort opened this issue Sep 11, 2024 · 0 comments · Fixed by #1989
Closed

Pass Config to wasmvm and make WasmLimits available to contract dev #1986

chipshort opened this issue Sep 11, 2024 · 0 comments · Fixed by #1989

Comments

@chipshort
Copy link
Collaborator

chipshort commented Sep 11, 2024

requires #1981

  • provide a way to x/wasm users to pass in the Config implemented in Implement Config that is passed from wasmd to cosmwasm-vm wasmvm#559
    • it contains the contract memory limit, the memory cache size from the existing WasmConfig and also the availableCapabilities and the path for the base directory of the cache (currently this is the homeDir provided by the user suffixed with "/wasm").
    • we don't necessarily have to expose the Config to the user. They could also just pass the parts (as is done now) and we build the Config from that. But exposing it makes it easier to extend in the future.
  • provide a WasmLimitsConfig query for the WasmLimits inside the config that returns it as a json string such that users have a way to get the config from the chain. This is needed such that contract developers can provide it to cosmwasm-check
    .
    • Note: If there is a better way to do this than a query or we rename this then that's fine, but we need to adjust the cosmwasm-check help text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant