-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more metadata along with contract #251
Comments
@alpe @webmaster128 I would be curious for your opinions here when you have time. Nothing urgent, just may be a nice polish for 1.0. |
I like the idea to store metadata. 🌷 I can imagine that we want to store metadata with codes and contracts separately. For example: the code was audited by xxxx, the contract UI runs on IP: yyyy |
@webmaster128 any opinions, feedback here? I know cosmjs will be the largest provider/consumer of such metadata, so it would be good to know your desires to make the customer happy 😄 |
Some of this data is good to have. I like the JSON Schema, as an interface description. I'm highly sceptical with respect to TypeScript types. I don't consider the JSON Schema -> .d.ts super stable and would also avoid to have better support for one client technology than for others. JSON Schema is stable and universal. As mentioned elsewhere, I think it is a serious security issue to add helper scripts to the chain. Users will execute them in a node process with their current user's pevillages no matter what they contain. I'd rather have a service that creates the helper scripts dynamically based on some variables than users storing arbitrary code on chain. Also things like fees and RPC endpoints are probably not stable for the lifetime of the contract. Re: source code |
Closing for the same reason as #241 (comment) This is too much logic to put in a blockchain, we should put that in an explorer "web app" or "api service" that allows a lot more fleixibllity to iterate and run long-lived tasks |
The builds on and extends #241 which is a great idea.
When we upload code, we upload a ~200kB wasm blob.
There is no reason we cannot add even 20kB of metadata like schemas and other references. Let's collect more ideas besides the JSON schemas and see which make sense:
I wonder if this makes sense to add all of them on the Code itself, or as annotations. In this case, the key technical items - schemas, ts interface, maybe source code would go on the Code. We would then allow any number of "Annotations" that can be attached to a Code blob, not only by the owner. These are suggestions, as
{Type, URL}
pairsThe text was updated successfully, but these errors were encountered: