-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused flag in gov proposals #849
Milestone
Comments
I remember that this was used when reading a json file for the gov proposal, once. But this may not be the case anymore 🤷 |
Adding it to v0.28.0. If this is possible without breaking the json import, let's do it. If not, let's just leave it as is (and close as "wont fix") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
flagProposalType
is being set in all gov proposals but only used in the sdk for the mainsubmit-proposal
command https://github.com/cosmos/cosmos-sdk/blob/v0.45.4/x/gov/client/cli/parse.go#L13We should consider removing it if it's not actually used.
Context: #796 (comment)
The text was updated successfully, but these errors were encountered: