Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of supported capabilities to set or array of strings #425

Closed
webmaster128 opened this issue Apr 18, 2023 · 0 comments · Fixed by #492
Closed

Change type of supported capabilities to set or array of strings #425

webmaster128 opened this issue Apr 18, 2023 · 0 comments · Fixed by #492
Milestone
2.0.0

Comments

@webmaster128
Copy link
Member

In

wasmvm/lib.go

Line 31 in a2cb78b

func NewVM(dataDir string, supportedCapabilities string, memoryLimit uint32, printDebug bool, cacheSize uint32) (*VM, error) {
we should accept more structured data and internalize the string representation of supported capabilities.

Ideally we can use a set but as far as I can tell there as no sets in Go. We can also use a []string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Make supportedCapabilities a slice CosmWasm/wasmvm
1 participant
@webmaster128