Skip to content

Commit 49afe5a

Browse files
committed
fix: [PROD-11969] minor improvements in error code display in SimplePowerBIReportEmbed
- allow status code without text (and vice-versa) - remove dash between status code and status text
1 parent e660eb4 commit 49afe5a

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

src/charts/SimplePowerBIReportEmbed/SimplePowerBIReportEmbed.js

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,12 @@ const useStyles = makeStyles((theme) => ({
5050
}));
5151

5252
function getErrorCode(labels, reports) {
53-
let errorCode = labels.errors.unknown;
54-
if (reports?.error?.status && reports?.error?.statusText) {
55-
errorCode = `${reports?.error?.status} - ${reports?.error?.statusText}`;
56-
}
57-
return errorCode;
53+
if (!reports?.error?.status && !reports?.error?.statusText) return labels.errors.unknown;
54+
return `${reports?.error?.status ?? ''} ${reports?.error?.statusText ?? ''}`;
5855
}
5956

6057
function getErrorDescription(labels, reports) {
61-
let errorDescription = labels.errors.details;
62-
if (reports?.error?.powerBIErrorInfo) {
63-
errorDescription = reports?.error?.powerBIErrorInfo;
64-
}
65-
return errorDescription;
58+
return reports?.error?.powerBIErrorInfo ?? labels.errors.details;
6659
}
6760

6861
function addDynamicParameters(pageName, lang, newConfig, settings, staticFilters, additionalFilters) {
@@ -256,6 +249,7 @@ export const SimplePowerBIReportEmbed = ({
256249
</div>
257250
);
258251
};
252+
259253
SimplePowerBIReportEmbed.propTypes = {
260254
/**
261255
* Index of reportConfiguration

0 commit comments

Comments
 (0)