feat: Prepare for multilingual support #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this causes any side effects
Bundle difference
|
jnnwnk
commented
Nov 4, 2020
| @@ -52,7 +52,9 @@ export const App = () => { | |||
| </Suspense> | |||
| <IntermediateProgress /> | |||
| {config.content?.pages.map((page, id) => ( | |||
| <RenderPageRoute key={id} page={page} /> | |||
| <Suspense key={id} fallback={getFallbackComponent()}> | |||
There was a problem hiding this comment.
Not sure if this causes any unwanted side effects? If there is any other solution, feel free to modify or comment. 🙂
Without Suspense component, UI will not render if useTranslation hook is in use (error message: A React component suspended while rendering, but no fallback UI was specified).
jnnwnk
changed the title
Bundle difference
|
Bundle difference
|
Bundle difference
|
jnnwnk
changed the title
Bundle difference
|
Bundle difference
|
DanielHabenicht
approved these changes
Nov 5, 2020
jnnwnk
changed the title
Bundle difference
|
jnnwnk
commented
Nov 6, 2020
| @@ -96,8 +96,9 @@ export const WelcomeModalPostalCode: React.FC = () => { | |||
| <div style={{ display: "flex", flexDirection: "row", alignItems: "center", marginBottom: "10px" }}> | |||
| <Checkbox value={checked} checked={checked} onChange={handleCheckedChange} /> | |||
| <Typography className={classes.smallText} style={isCheckboxError ? { color: "red" } : {}}> | |||
| Ja, ich habe die <Link to={WelcomeModalStep.StepPostalCodeDataPrivacy}>Datenschutzerklärung</Link> zur | |||
| Kenntnis genommen und willige ein. | |||
| <Trans t={t} i18nKey="welcome.regional-risk.accept-privacy"> | |||
There was a problem hiding this comment.
Not sure why we have to pass t explicitly here. If anybody has an idea, please let me know. 🙂
Bundle difference
|
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.