Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

wrong Contao minimum requirement #4

Open
fritzmg opened this issue Dec 7, 2017 · 3 comments
Open

wrong Contao minimum requirement #4

fritzmg opened this issue Dec 7, 2017 · 3 comments

Comments

@fritzmg
Copy link

fritzmg commented Dec 7, 2017

The usage of the Contao\StringUtil class was introduced in aafe84f. However, this class is only present in Contao >=3.5.1 - yet the composer.json still has^3.2 || ^4.2 as the minimum requirement.

This will lead to a

 Class 'Contao\StringUtil' not found

in earlier Contao versions after a composer update.

@fritzmg
Copy link
Author

fritzmg commented Dec 7, 2017

For anyone encountering this in one of their old Contao installations, you can add

    "conflict": {
        "icodr8/contao-photoalbums2": "1.6.0",
        "craffft/contao-imagesortwizard": "2.3.1"
    },

to your composer.json and then run an update again.

(See also Craffft/contao-photoalbums2#136)

@iCodr8
Copy link
Contributor

iCodr8 commented Jan 29, 2018

Can you fix it in a pull request?

@fritzmg
Copy link
Author

fritzmg commented Jan 29, 2018

Hm... well you would need to change the minimum contao version (which I could do in a PR request), release it as 2.3.2 and then delete the 2.3.1 tag. However deleting a tag is something you should not do - but I do not know how else to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants