Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic code check in RetryFailedPartitionJob #1539

Closed
woksin opened this issue Nov 22, 2024 · 0 comments · Fixed by #1573
Closed

Magic code check in RetryFailedPartitionJob #1539

woksin opened this issue Nov 22, 2024 · 0 comments · Fixed by #1573
Labels
jobs Issues related to the job system

Comments

@woksin
Copy link
Contributor

woksin commented Nov 22, 2024

I don't understand this SuccessfulSteps check:

 /// <inheritdoc/>
  public override async Task OnCompleted()
    {
        if (State.Progress.SuccessfulSteps == 1)
        {
            var observer = GrainFactory.GetGrain<IObserver>(Request.ObserverKey);
            await observer.FailedPartitionRecovered(Request.Key);
        }
    }
@einari einari added the jobs Issues related to the job system label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jobs Issues related to the job system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants