quit find after one match, adjust test accordingly #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
dborman-hpe
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
LGTM.
FYI I checked this on mug, and verified that it doesn't matter which of the multiple responses is used, they all report the same information.
ncn-m001:~ # md5sum `find /sys/fs/cgroup -path '*/goss-servers.service/cgroup.procs' -type f`
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/pids/system.slice/goss-servers.service/cgroup.procs
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/blkio/system.slice/goss-servers.service/cgroup.procs
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/memory/system.slice/goss-servers.service/cgroup.procs
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/devices/system.slice/goss-servers.service/cgroup.procs
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/cpu,cpuacct/system.slice/goss-servers.service/cgroup.procs
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/systemd/system.slice/goss-servers.service/cgroup.procs
21ca286f5674493404c310e736b3a70d /sys/fs/cgroup/unified/system.slice/goss-servers.service/cgroup.procs
|
Yeah @dborman-hpe I noticed this as well, which is why I changed it to just one match. There may be a better way to get the pids with Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.