CASMPET-7273: k8s-verify-cluster: Allow etcdbackup pods in states other than Running and Completed #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than Running and Completed
mharding-hpe
requested review from
mtupitsyn,
bo-quan,
leliasen-hpe,
a team,
rustydb,
OneMoreByte,
mbuchmann-hpe,
schooler-hpe,
jnowicki-hpe,
kimjensen-hpe,
spillerc-hpe,
ndavidson-hpe and
jpdavis-prof
|
/backport release/1.5 release/1.4 |
|
Backporting into branch release/1.5 was successful. New PR: #632 |
|
Backporting into branch release/1.4 was successful. New PR: #633 |
jacobsalmela
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails if it finds any pods in the
kube-systemnamespace that are notRunningorCompleted. In most cases, this is fine, but if it happens to run while anetcdbackupjob pod is starting up or terminating, then it may catch that pod in states likeContainerCreatingorTerminating. Basically, there are non-error states that those pods may be found in. This PR updates the test so that when checking thekube-systemnamespace, it fails if:etcdbackuppod is in a state other thanRunningorCompletedetcdbackuppod is in a state other thanRunning,Completed,ContainerCreating,Init:#/#,NotReady,Pending,PodInitializing, orTerminating.This will avoid the false failure that Mikhail reported when opening this ticket.
I have tested this on mug and ran the test repeatedly, verifying that it now correctly handles the case where an
etcdbackuppod is in one of the other valid states.