Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enchantments in items filter dissapearing after applying #7214

Open
tekutora opened this issue Dec 15, 2024 · 2 comments · May be fixed by #7216
Open

enchantments in items filter dissapearing after applying #7214

tekutora opened this issue Dec 15, 2024 · 2 comments · May be fixed by #7216
Labels
type: bug Issue where something isn't working

Comments

@tekutora
Copy link

Description

put enchanted sword in item filter and use respect data >
apply filter and put it in deployer >
filter not working >
take filter from deployer
open and see that item that i putted in there are not enchanted

Base.Profile.2024.12.15.-.21.25.43.02.1.mp4

Game Log

dasdsaasd

Debug Information

No response

@tekutora tekutora added the type: bug Issue where something isn't working label Dec 15, 2024
@VoidLeech
Copy link
Contributor

Introduced in fa5b71b, notice how the Enchantments and AttributeModifier data is removed before the checks for whether the itemstack is a filter/attribute filter:

public static FilterItemStack of(ItemStack filter) {
if (filter.hasTag()) {
CompoundTag stackTag = filter.getTag();
stackTag.remove("Enchantments");
stackTag.remove("AttributeModifiers");
if (AllItems.FILTER.isIn(filter))
return new ListFilterItemStack(filter);
if (AllItems.ATTRIBUTE_FILTER.isIn(filter))
return new AttributeFilterItemStack(filter);
}
return new FilterItemStack(filter);

@tekutora
Copy link
Author

so what should i do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants